[
https://issues.apache.org/jira/browse/IGNITE-22554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Polovtsev updated IGNITE-22554:
-----------------------------------------
Fix Version/s: 3.0.0-beta2
> Rename confusing variables in TableManager
> ------------------------------------------
>
> Key: IGNITE-22554
> URL: https://issues.apache.org/jira/browse/IGNITE-22554
> Project: Ignite
> Issue Type: Improvement
> Reporter: Aleksandr Polovtsev
> Assignee: Aleksandr Polovtsev
> Priority: Minor
> Labels: ignite-3
> Fix For: 3.0.0-beta2
>
>
> {{TableManager}} contains the following code:
> {code:java}
> Assignments nonStableNodeAssignments = pendingAssignmentsAreForced
> ? Assignments.forced(intersect(stableAssignments,
> pendingAssignmentsNodes))
> : Assignments.of(stableAssignments);
> {code}
> This variable's name is very confusing, because somebody can think that it
> contains "non stable" a.k.a. "pending assignments", whereas it actually
> contains stable assignments (yes, we assign stable assignments to a variable
> called "nonStableNodeAssignments"). Actually, it already led to confusion as,
> for example, method {{TableManager#shouldStartRaftListeners}} treats
> "nonStableNodeAssignments" as pending assignments, which is incorrect.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
