[ 
https://issues.apache.org/jira/browse/IGNITE-22861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871967#comment-17871967
 ] 

Andrey Mashenkov commented on IGNITE-22861:
-------------------------------------------

We need a refactoring. 
For now, we read a LogicalTopology, then read assignments for fragment mapping.

We use LogicalTopology for both: ensure cached mapping is valid and enumerate 
nodes, to operate node order (int) instead of consistentId (String) for 
collocation calculation.

The issue here, the logical topology may be changed in between, which lead to 
an error when we try to resolve node order from assignment against outdated 
topology.
Also, assignments has no connection with logical topology. So, we have to 
rethink this part.

> Sql. Calculation for mapOnBackups parameter erased.
> ---------------------------------------------------
>
>                 Key: IGNITE-22861
>                 URL: https://issues.apache.org/jira/browse/IGNITE-22861
>             Project: Ignite
>          Issue Type: Bug
>          Components: sql
>    Affects Versions: 3.0.0-beta1
>            Reporter: Evgeny Stanilovsky
>            Assignee: Andrey Mashenkov
>            Priority: Major
>              Labels: ignite-3
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> After [1] was implemented it`s become possible to run queries on backup nodes 
> but for now it erased, check implementation:
> {noformat}
> boolean mapOnBackups = tx.isReadOnly();
> MappingParameters mappingParameters = 
> MappingParameters.create(ctx.parameters(), mapOnBackups);
> {noformat}
> {noformat}
> public static MappingParameters create(Object[] dynamicParameters, boolean 
> mapOnBackups) {
>         if (dynamicParameters.length == 0) {
>             return EMPTY;
>         } else {
>             return new MappingParameters(dynamicParameters, mapOnBackups);
>         }
>     }
> {noformat}
> [1] IGNITE-22466 Sql. Support mapping to non-primary replicas



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to