[
https://issues.apache.org/jira/browse/IGNITE-22917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873179#comment-17873179
]
Ilya Shishkov edited comment on IGNITE-22917 at 8/13/24 11:43 AM:
------------------------------------------------------------------
{{GridDhtLockRequest#addNearKey(KeyCacheObject)}} was removed in commit [1] in
February 2015. Thus, this method seems to be useless.
#
https://github.com/apache/ignite/commit/212293eb2bede9cca6610e7c43e870ab386bd3f8#diff-86a6708705e89463e914e03aff750e5bd7e5641eb568b9d0a7bbd9e62e7c81c4L944
was (Author: shishkovilja):
{{GridDhtLockRequest#addNearKey(KeyCacheObject)}} was removed in commit [1] in
February 2015. Thus, this method seems to be useless.
https://github.com/apache/ignite/commit/212293eb2bede9cca6610e7c43e870ab386bd3f8#diff-86a6708705e89463e914e03aff750e5bd7e5641eb568b9d0a7bbd9e62e7c81c4L944
> Remove GridDhtLockRequest#nearKeys
> ----------------------------------
>
> Key: IGNITE-22917
> URL: https://issues.apache.org/jira/browse/IGNITE-22917
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Ilya Shishkov
> Assignee: Ilya Shishkov
> Priority: Minor
> Labels: ise
>
> {{GridDhtLockRequest#addNearKey(KeyCacheObject)}} does not have any usage,
> i.e. {{GridDhtLockRequest#nearKeys}} is not updated at all.
> So, {{nearKeys}} always returns empty collection and, moreover, some code
> becomes useless, eg. {{GridNearTransactionalCache#startRemoteTx(UUID,
> GridDhtLockRequest)}} [1], etc.
> We have to figure out whether this is redundant code or whether we have
> *_lost some useful functionality_*.
> #
> https://github.com/apache/ignite/blob/f4654f98607648252c5164c0fd1a81eff279ca26/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTransactionalCache.java#L285
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
