[
https://issues.apache.org/jira/browse/IGNITE-22918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873222#comment-17873222
]
Ilya Shishkov edited comment on IGNITE-22918 at 8/13/24 4:48 PM:
-----------------------------------------------------------------
{{GridDhtLockResponse#nearEvicted()}} usage was removed in commit in February
2015, see [1-3]. Thus, this method seems to be useless.
#
https://github.com/apache/ignite/commit/212293eb2bede9cca6610e7c43e870ab386bd3f8#diff-86a6708705e89463e914e03aff750e5bd7e5641eb568b9d0a7bbd9e62e7c81c4L1136
#
https://github.com/apache/ignite/commit/212293eb2bede9cca6610e7c43e870ab386bd3f8#diff-86a6708705e89463e914e03aff750e5bd7e5641eb568b9d0a7bbd9e62e7c81c4L1141
#
https://github.com/apache/ignite/commit/212293eb2bede9cca6610e7c43e870ab386bd3f8#diff-86a6708705e89463e914e03aff750e5bd7e5641eb568b9d0a7bbd9e62e7c81c4L1144
was (Author: shishkovilja):
{{GridDhtLockResponse#nearEvicted()}} was removed in commit in February 2015,
see [1-3]. Thus, this method seems to be useless.
#
https://github.com/apache/ignite/commit/212293eb2bede9cca6610e7c43e870ab386bd3f8#diff-86a6708705e89463e914e03aff750e5bd7e5641eb568b9d0a7bbd9e62e7c81c4L1136
#
https://github.com/apache/ignite/commit/212293eb2bede9cca6610e7c43e870ab386bd3f8#diff-86a6708705e89463e914e03aff750e5bd7e5641eb568b9d0a7bbd9e62e7c81c4L1141
#
https://github.com/apache/ignite/commit/212293eb2bede9cca6610e7c43e870ab386bd3f8#diff-86a6708705e89463e914e03aff750e5bd7e5641eb568b9d0a7bbd9e62e7c81c4L1144
> Remove GridDhtLockResponse#nearEvicted
> --------------------------------------
>
> Key: IGNITE-22918
> URL: https://issues.apache.org/jira/browse/IGNITE-22918
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Ilya Shishkov
> Assignee: Ilya Shishkov
> Priority: Minor
> Labels: ise
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{GridDhtLockResponse#nearEvicted()}} method does not have any usage, i.e.
> {{GridDhtLockResponse#nearEvicted}} field update has no further effect [1, 2].
> We have to figure out whether this is redundant code or whether we have
> *_lost some useful functionality_*.
> #
> https://github.com/apache/ignite/blob/f4654f98607648252c5164c0fd1a81eff279ca26/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTransactionalCacheAdapter.java#L529
> #
> https://github.com/apache/ignite/blob/f4654f98607648252c5164c0fd1a81eff279ca26/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTransactionalCacheAdapter.java#L540
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
