[jira] [Commented] (IGNITE-23178) Calcite. Least restrictive type priority DOUBLE over FLOAT

[Ignite TC Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/IGNITE-23178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884235#comment-17884235
 ] 

Ignite TC Bot commented on IGNITE-23178:
----------------------------------------

{panel:title=Branch: [pull/11520/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/11520/head] Base: [master] : New Tests 
(11)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Calcite SQL{color} [[tests 
11|https://ci2.ignite.apache.org/viewLog.html?buildId=8081627]]
* {color:#013220}IgniteCalciteTestSuite: 
NumericTypesPrecisionsTest.testMaxPrecision - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite: 
NumericTypesPrecisionsTest.testLeastRestrictiveFloat - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite: 
NumericTypesPrecisionsTest.testMaxNumericScale - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite: 
NumericTypesPrecisionsTest.testDefaultPrecision - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite: 
NumericTypesPrecisionsTest.testLeastRestrictiveTinyInt - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite: 
NumericTypesPrecisionsTest.testMaxNumericPrecision - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite: 
NumericTypesPrecisionsTest.testLeastRestrictiveSmallInt - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite: 
NumericTypesPrecisionsTest.testLeastRestrictiveDecimal - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite: 
NumericTypesPrecisionsTest.testLeastRestrictiveDouble - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite: 
NumericTypesPrecisionsTest.testLeastRestrictiveBigInt - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite: 
NumericTypesPrecisionsTest.testLeastRestrictiveInteger - PASSED{color}
... and 0 new tests

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=8081704&buildTypeId=IgniteTests24Java8_RunAll]

> Calcite. Least restrictive type priority DOUBLE over FLOAT
> ----------------------------------------------------------
>
>                 Key: IGNITE-23178
>                 URL: https://issues.apache.org/jira/browse/IGNITE-23178
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Vladimir Steshin
>            Assignee: Vladimir Steshin
>            Priority: Minor
>              Labels: calcite, ise
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Calcite derives least restrictive approximate numeric type by comparing the 
> precisions. While _FLOAT_ has the same precision as _DOUBLE_ (currently 15), 
> the least restrictive type may variate between them and issue _FLOAT_ instead 
> of _DOUBLE_. DOUBLE is more preferable:
> {code:java}
> IgniteTypeFactory#leastRestrictive(List<RelDataType> types) 
> {code}
> may produce _FLOAT_ when _types_ has a _DOUBLE_.
> Adoption of IGNITE-18556



--
This message was sent by Atlassian Jira
(v8.20.10#820010)