[
https://issues.apache.org/jira/browse/IGNITE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394077#comment-15394077
]
Jens Hoffmann edited comment on IGNITE-3323 at 7/26/16 4:57 PM:
----------------------------------------------------------------
Hi Anton, it seems that only the first part of the pull request was applied to
master, see property **jetbrains.annotations.version** in **parent/pom.xml**:
- On ignite master it is set to **15.0**:
https://github.com/apache/ignite/blob/master/parent/pom.xml
- On my branch it is set to **13.0**:
https://github.com/jayho/ignite/blob/ignite-3323/parent/pom.xml
The **annotations-15.0.jar** seems to have been compiled under java 8 (class
file major version 52) whereas **annotations-13.0.jar**'s contents have class
file major version 49.
Will this not cause problems as you're still supposed to compile ignite under
java 7? I thought I saw test failures hence I added another commit changing the
version to 13.0...
was (Author: thehoff):
Hi Anton, it seems that only the first part of the pull request was applied to
master, see property ${jetbrains.annotations.version} in parent pom.xml:
- On ignite master it is set to 15.0:
https://github.com/apache/ignite/blob/master/parent/pom.xml
- On my branch it is set to 13.0:
https://github.com/jayho/ignite/blob/ignite-3323/parent/pom.xml
The annotations-15.0.jar seems to have been compiled with java 8 (class file
major version 52) whereas annotations-13.0.jar's contents have class file major
version 49. Will this not cause problems as you're still supposed to compile
ignite under java 7?
> Get rid of copypasted JB annotations, use dependency instead.
> -------------------------------------------------------------
>
> Key: IGNITE-3323
> URL: https://issues.apache.org/jira/browse/IGNITE-3323
> Project: Ignite
> Issue Type: Task
> Affects Versions: 1.5.0.final
> Reporter: Anton Vinogradov
> Assignee: Jens Hoffmann
> Priority: Minor
> Labels: newbie
> Fix For: 1.7
>
>
> From user request:
> {quote}
> I've come across an issue where there are a couple of classes duplicated from
> org.jetbrains.annotations within the ignite-core module which conflict with
> other part of our code base.
> As these files are duplicated rather than being referenced as a maven
> dependency I am unable to exclude them or reference a specific version of the
> org.jetbrains.annotations artifact.
> Specifically, the included version cannot be used to annotate types
> ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ...
> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER,
> ElementType.LOCAL_VARIABLE})
> annotations-15.0.jar:org.jetbrains.annotations.Nullable ...
> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER,
> ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE})
> As far as I know there isn't an easy way of excluding these files from within
> the ignite-core module. Is there are reason why these "external" files have
> been duplicated within the ignite code base rather than being referenced as a
> maven dependency? Or alternatively, has anyone come across a way of avoiding
> these conflicts?
> {quote}
> Seems we have to remove these classes from Ignite code and use maven
> dependency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
