[
https://issues.apache.org/jira/browse/IGNITE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885237#comment-17885237
]
Kirill Tkalenko commented on IGNITE-23103:
------------------------------------------
Looks good.
> RandomLruPageReplacementPolicy is not fully ported
> --------------------------------------------------
>
> Key: IGNITE-23103
> URL: https://issues.apache.org/jira/browse/IGNITE-23103
> Project: Ignite
> Issue Type: Bug
> Reporter: Ivan Bessonov
> Assignee: Aleksandr Polovtsev
> Priority: Major
> Labels: ignite-3
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> There should be a line
> {code:java}
> if (relRmvAddr == rndAddr || pinned || skip || (dirty && (checkpointPages ==
> null || !checkpointPages.contains(fullId)))) {{code}
> instead of
> {code:java}
> if (relRmvAddr == rndAddr || pinned || skip || dirty) { {code}
> Due to this mistake we have several conditions, that are always evaluated to
> constants, namely
> *
> {{!dirty}} - always true
> *
> {{pageTs < dirtyTs && dirty && !storMeta}} - always false
> Ideally, we should add tests that would cover this situation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
