[
https://issues.apache.org/jira/browse/IGNITE-23060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886550#comment-17886550
]
Pavel Pereslegin edited comment on IGNITE-23060 at 10/3/24 8:27 AM:
--------------------------------------------------------------------
Looks like the issue is not valid. These checks should not be combined
(typeFamiliesAreCompatible shows whether types belong to the same family, but
IgniteCustomAssignmentsRules shows rules for explicit casts).
In IGNITE-23042 TODOs left in the code have been resolved.
was (Author: xtern):
Fixed in IGNITE-23042
> Sql. Move rules from typeFamiliesAreCompatible into
> IgniteCustomAssignmentsRules
> --------------------------------------------------------------------------------
>
> Key: IGNITE-23060
> URL: https://issues.apache.org/jira/browse/IGNITE-23060
> Project: Ignite
> Issue Type: Improvement
> Components: sql
> Reporter: Pavel Pereslegin
> Priority: Major
> Labels: ignite-3
>
> {{TypeUtils.typeFamiliesAreCompatible}} checks that types have compatible
> type families taking into account custom data types (types have compatible
> type families if type can be assigned to another type and vice-versa)
> {{IgniteCustomAssignmentsRules}} is more relaxed and determines whether a
> type is assignable from another type , but doesn't take into account custom
> types (currently it operates with {{SqlTypeName}}, not {{RelDataType}}).
> Looks like we need to move checks from {{typeFamiliesAreCompatible}} into
> {{IgniteCustomAssignmentsRules}} if possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
