[ 
https://issues.apache.org/jira/browse/IGNITE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399397#comment-15399397
 ] 

Eduard Shangareev edited comment on IGNITE-3513 at 7/29/16 2:24 PM:
--------------------------------------------------------------------

Benchmark result (16 thread, ops/ms):
||Version||100%||50%||0%||
|ignite-3513|331.856 ± 6.707|331.423 ±7.889|351.278 ± 11.186|
|ignite-1.6.3|345.594 ± 4.178|341.676 ± 8.279|351.402 ± 5.065|

A multithreaded test was added. 
GridCacheTtlManagerNotificationTest was rewritten on public API usage.


was (Author: edshanggg):
Benchmark result (16 thread, ops/ms):
||Version||100%||50%||0%||
|ignite-3513|331.856 ± 6.707|331.423 ±7.889|350.171 ± 42.268|
|ignite-1.6.3|345.594 ± 4.178|341.676 ± 8.279|351.402 ± 5.065|

A multithreaded test was added. 
GridCacheTtlManagerNotificationTest was rewritten on public API usage.

> Cleanup worker is placed in the Thread's waiting queue using Thread.sleep 
> method
> --------------------------------------------------------------------------------
>
>                 Key: IGNITE-3513
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3513
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 1.6
>            Reporter: Denis Magda
>            Assignee: Semen Boikov
>             Fix For: 1.7
>
>
> There is a bug in current implementation of 
> {{GridCacheTtlManager#CleanupWorker}}.
> Refer to the implementation's code snippet and the details below.
> {code}
> EntryWrapper first = pendingEntries.firstx();
>  if (first != null) {
>    long waitTime = first.expireTime - U.currentTimeMillis();
>    if (waitTime > 0)
>       U.sleep(waitTime);
>  }
> {code}
> 1. Put first item with TTL = 1 hour. CleanupWorker will go to sleep for 1 
> hour.
> 2. Put second item with TTL = 1 minute. Since 
> CleanupWorker's thread sleeps now, second item will not be expired at the 
> time.
> NOTE: This scenario is easily to reproducible if first and second items are 
> put into cache asynchronously. If try to put them in same thread one-by-one 
> expiration may work fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to