[ 
https://issues.apache.org/jira/browse/IGNITE-23268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894161#comment-17894161
 ] 

Igor Sapego commented on IGNITE-23268:
--------------------------------------

Looks good to me.

> Incorrect mapping for java.util.Date in catalog's ColumnType
> ------------------------------------------------------------
>
>                 Key: IGNITE-23268
>                 URL: https://issues.apache.org/jira/browse/IGNITE-23268
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha5
>            Reporter: Tiago Marques Godinho
>            Assignee: Pavel Tupitsyn
>            Priority: Critical
>              Labels: ignite-3, important
>             Fix For: 3.0
>
>
> The catalog API is mapping "java.util.Date" to "date" column type.
> This is incorrect. It should be tagged with a "timestamp" column type because 
> it also has time information.
> I believe there was no intention to map a `java.util.Date` field in the first 
> place. It seems the author wanted to import `java.sql.Date` instead, since 
> there are other classes from the `sql` package mapped and none of the old 
> java classes are mapped.
> Perhaps it is worth to review the parity between the catalog API mappins and 
> the mappings in the [ignite-sql 
> package|https://github.com/apache/ignite-3/blob/a51a7fe483528f801edac6313cd094e0ccabda2a/modules/api/src/main/java/org/apache/ignite/sql/ColumnType.java].
>  
> Links:
> * 
> [Definition|https://github.com/apache/ignite-3/blob/7684d7c0c86b482919cfd98e9477b008c2472d4b/modules/api/src/main/java/org/apache/ignite/catalog/ColumnType.java#L101-L102]
> * [Import 
> statement|https://github.com/apache/ignite-3/blob/7684d7c0c86b482919cfd98e9477b008c2472d4b/modules/api/src/main/java/org/apache/ignite/catalog/ColumnType.java#L21-L23]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to