[ 
https://issues.apache.org/jira/browse/IGNITE-23650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899713#comment-17899713
 ] 

Ignite TC Bot commented on IGNITE-23650:
----------------------------------------

{panel:title=Branch: [pull/11650/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/11650/head] Base: [master] : No new tests 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All* 
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=8172662&buildTypeId=IgniteTests24Java8_RunAll]

> Calcite engine. Refactor IndexScan/TableScan classes hierarchy
> --------------------------------------------------------------
>
>                 Key: IGNITE-23650
>                 URL: https://issues.apache.org/jira/browse/IGNITE-23650
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Aleksey Plekhanov
>            Assignee: Aleksey Plekhanov
>            Priority: Major
>              Labels: calcite2-required, ise
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> We have duplicated code related to partition reservation for 
> {{IndexScan}}/{{TableScan}} classes. It would be better to have common parent 
> class (for example, {{AbstractCacheScan}}) for both of these classes. But 
> {{IndexScan}} is inherited from {{AbstractIndexScan}}, and this class also 
> used by {{RuntimeSortedIndex}}, so {{AbstractIndexScan}} can be inherited 
> from {{AbstractCacheScan}}. {{RuntimeSortedIndex}} redefine most of the 
> methods of {{AbstractIndexScan}} as no-op, and it would be better to use some 
> kind of tree iterator in {{RuntimeSortedIndex}} instead of 
> {{AbstractIndexScan}}.
> This refactoring is also required for IGNITE-23562 (the new node 
> {{IndexCountScan}} can be a child of {{AbstractCacheScan}}).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to