[ 
https://issues.apache.org/jira/browse/IGNITE-23039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904793#comment-17904793
 ] 

Pavel Pereslegin edited comment on IGNITE-23039 at 12/11/24 1:34 PM:
---------------------------------------------------------------------

Calcite sarg serialization сгккутедн doesnэt support binary type conditions.
This can be fixed by copy-pasting lot of code from RelJson.
[PR|https://github.com/apache/ignite-3/pull/4853] contains POC that works with 
calcite 1.37 (and produces some unexpected errors in tests with calcite 1.38).
We decided that this fix does not add significant value and may contain 
additional bugs that are currently hidden (e.g. UUID serialization needs to be 
checked as well) and may introduce bugs in the future.


was (Author: xtern):
Calcite sarg serialization does not support binary type conditions.
This can be fixed by copy-pasting lot of code from RelJson.
[PR|https://github.com/apache/ignite-3/pull/4853] contains POC that works with 
calcite 1.37 (and produces some unexpected errors in tests with calcite 1.38).
We decided that this fix does not add significant value and may contain 
additional bugs that are currently hidden (e.g. UUID serialization needs to be 
checked as well) and may introduce bugs in the future.

> Sql. Add support for Sarg serialization/deserialization
> -------------------------------------------------------
>
>                 Key: IGNITE-23039
>                 URL: https://issues.apache.org/jira/browse/IGNITE-23039
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>            Reporter: Pavel Pereslegin
>            Assignee: Pavel Pereslegin
>            Priority: Major
>              Labels: ignite-3
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently when serializing {{Sarg}} ({{SEARCH}} operator) we converting it to 
> OR (using {{Rextil.exapndSearch()}}) .
> But since 1.35 calcite supports  serialization of {{Sarg}} (see CALCITE-5614).
> Need to port this code to AI.
> p.s. check TODOs
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to