[
https://issues.apache.org/jira/browse/IGNITE-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413417#comment-15413417
]
Andrey Gura commented on IGNITE-3407:
-------------------------------------
[~samaitra] Thank you for contribution. I have a few comments about your
changes:
* Checkinf of {{pageSize}} parameter occures after query was performed and
iterator was returned. Better place for checking this parameter is
{{QueryCommandHandler.handleAsync()}} method for all cases except of
{{CLOSE_SQL_QUERY}}. Earlier parameters verification allows to avoid redundant
objects allocations and remote calls.
* Use {{GridRestCommandHandlerAdapter.missingParameter()}} method in order to
create error message. See usages of this method.
* {{IgniteCheckedException}} should be thrown instead of {{IgniteException}}
in case of mandatory parameter is missing. Again see usages of
{{GridRestCommandHandlerAdapter.missingParameter()}} method.
* Apache Ignite should compile under Java 7. {{GridQueryCommandHandlerTest}}
class contains {{Class.getTypeName()}} calls. There is no such method in Java 7.
* Use {{GridAbstractTest.getConfiguration(String gridName)}} method in order
to configure Ignite instances in tests. See usages of this method in other test
classes.
Could you please fix this comments?
> HTTP REST: query commands without pageSize failed with NPE
> ----------------------------------------------------------
>
> Key: IGNITE-3407
> URL: https://issues.apache.org/jira/browse/IGNITE-3407
> Project: Ignite
> Issue Type: Bug
> Components: general
> Affects Versions: 1.6
> Reporter: Andrey Novikov
> Assignee: Saikat Maitra
> Fix For: 1.8
>
>
> org/apache/ignite/internal/processors/rest/handlers/query/QueryCommandHandler.java:125
> Need return response with error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
