[
https://issues.apache.org/jira/browse/IGNITE-24921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roman Puchkovskiy updated IGNITE-24921:
---------------------------------------
Description:
ReplicaStateManager is currently an inner class of ReplicaManager.
# ReplicaStateManager is a cohesive piece of code having well-defined
responsibilities, so it is ok to make it a top-level class
# The current state of affairs does not allow to test ReplicaStateManager
directly, even though it is logic-rich
# ReplicaManager alone (without ReplicaStateManager) is 1000+ lines, which
makes it inconvenient to work with it
# ReplicaStateManager itself is 400+ lines, which is a bit too much for an
internal class
Given all these, it seems beneficial to have ReplicaStateManager as a top-level
class.
> Make ReplicaStateManager a top-level class
> ------------------------------------------
>
> Key: IGNITE-24921
> URL: https://issues.apache.org/jira/browse/IGNITE-24921
> Project: Ignite
> Issue Type: Improvement
> Reporter: Roman Puchkovskiy
> Assignee: Roman Puchkovskiy
> Priority: Major
> Labels: ignite-3
> Time Spent: 10m
> Remaining Estimate: 0h
>
> ReplicaStateManager is currently an inner class of ReplicaManager.
> # ReplicaStateManager is a cohesive piece of code having well-defined
> responsibilities, so it is ok to make it a top-level class
> # The current state of affairs does not allow to test ReplicaStateManager
> directly, even though it is logic-rich
> # ReplicaManager alone (without ReplicaStateManager) is 1000+ lines, which
> makes it inconvenient to work with it
> # ReplicaStateManager itself is 400+ lines, which is a bit too much for an
> internal class
> Given all these, it seems beneficial to have ReplicaStateManager as a
> top-level class.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)