[
https://issues.apache.org/jira/browse/IGNITE-3138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419148#comment-15419148
]
Denis Magda commented on IGNITE-3138:
-------------------------------------
[~v.pyatkov], my points are the following:
1. You need to wrap that {{f.get()}} with a {{try-catch}} block storing a
possible exception in a local variable {{lastExc}} and allowing the rest of the
code to execute. At the very end of {{doFlush}} method execution you need to
throw {{lastExc}} if it's not {{null}}.
2. When pending buffers are being flushed in the following loop
{{for (IgniteInternalFuture fut = q.poll(); fut != null; fut = q.poll())}}
and if we get {{IgniteClientDisconnectedCheckedException}} or
{{IgniteFutureTimeoutCheckedException}} for the first future from the list then
it means that the rest futures won't be visited and triggered and some client
code can hang waiting while the rest futures are being completed.
This situation has to be considered as well.
[~yzhdanov], please join this thread sharing your thoughts.
> IgniteDataStreamer: failures are not shown on the streaming side
> ----------------------------------------------------------------
>
> Key: IGNITE-3138
> URL: https://issues.apache.org/jira/browse/IGNITE-3138
> Project: Ignite
> Issue Type: Bug
> Reporter: Denis Magda
> Assignee: Vladislav Pyatkov
> Attachments: DataStreamerFailuresTest.java
>
>
> If an exception happens during the streaming, the side that streams the data
> won't printed out anything in its logs even if IGNITE_QUIET set to false.
> This makes it's inconvenient to see whether there an issue happened during
> the streaming or not.
> Suggested improvements:
> - print out errors that happened during the streaming on the streaming side;
> - Future that is returned from {{addData}} methods is not called in case of
> error. This must be fixed. So that the user is able to write a custom logic
> around this feature and process errors somehow.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
