[ 
https://issues.apache.org/jira/browse/IGNITE-25647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17984944#comment-17984944
 ] 

Ivan Bessonov commented on IGNITE-25647:
----------------------------------------

{{CMG}} commands seem to absolutely be the same in {{3.0}} and {{{}main{}}}.

No issues noticed in {{{}meta-storage{}}}.

No issues in {{{}transactions{}}}.

{{{}replicator{}}}:
 * 
{{PrimaryReplicaChangeCommand}} is in the wrong package. That's not a 
compatibility issue, it's just a mistake that we should fix.

{{{}partition-replicator{}}}:
 * {{BuildIndexCommand}} now extends {{{}TableAwareCommand{}}}, which adds 
{{{}tableId{}}}.
 * {{FinishTxCommand}} changed {{List<TablePartitionIdMessage> partitionIds()}} 
to {{{}List<EnlistedPartitionGroupMessage> partitions(){}}}.
 ** 
{{EnlistedPartitionGroupMessage}} does not exist in {{{}Apache Ignite 3.0{}}}.
 ** {{TablePartitionIdMessage}} left unchanged.
 * 
{{UpdateAllCommand}} now extends {{{}TableAwareCommand{}}}, which adds 
{{{}tableId{}}}.
 * {{UpdateAllCommand}} changed {{TablePartitionIdMessage tablePartitionId()}} 
to {{{}ReplicationGroupIdMessage commitPartitionId(){}}}.
 ** It's a rename, properties are reordered now.
 ** There's no forward compatibility due to the existence of zone IDs. Should 
not be a problem.
 * Same issues with {{{}UpdateCommand{}}}.
 * {{WriteIntentSwitchCommand}} added {{{}Set<Integer> tableIds(){}}}.

That's about it, I'll add my thoughts on further steps later. Could have been 
worse.

> Fix RAFT messages incompatibility
> ---------------------------------
>
>                 Key: IGNITE-25647
>                 URL: https://issues.apache.org/jira/browse/IGNITE-25647
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Vadim Pakhnushev
>            Assignee: Ivan Bessonov
>            Priority: Major
>              Labels: ignite-3
>
> When upgrading from 3.0.0 to current version, node can't start with the 
> following exception:
> {noformat}
> Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 9 out of bounds 
> for length 6
>       at 
> org.apache.ignite.internal.raft.util.OptimizedStream.readInt(OptimizedStream.java:97)
>  ~[main/:?]
>       at 
> org.apache.ignite.internal.raft.util.OptimizedStream.readShort(OptimizedStream.java:68)
>  ~[main/:?]
>       at 
> org.apache.ignite.internal.network.direct.stream.DirectByteBufferStreamImplV1.readMessage(DirectByteBufferStreamImplV1.java:1586)
>  ~[main/:?]
>       at 
> org.apache.ignite.internal.network.direct.DirectMessageReader.readMessage(DirectMessageReader.java:473)
>  ~[main/:?]
>       at 
> org.apache.ignite.internal.partition.replicator.network.command.UpdateCommandDeserializer.readMessage(UpdateCommandDeserializer.java:39)
>  ~[main/:?]
>       at 
> org.apache.ignite.internal.network.direct.stream.DirectByteBufferStreamImplV1.readMessage(DirectByteBufferStreamImplV1.java:1604)
>  ~[main/:?]
>       at 
> org.apache.ignite.internal.raft.util.OptimizedMarshaller.unmarshall(OptimizedMarshaller.java:170)
>  ~[main/:?]
>       at 
> org.apache.ignite.internal.table.distributed.schema.PartitionCommandsMarshallerImpl.unmarshall(PartitionCommandsMarshallerImpl.java:62)
>  ~[main/:?]
>       at 
> org.apache.ignite.internal.table.distributed.schema.ThreadLocalPartitionCommandsMarshaller.unmarshall(ThreadLocalPartitionCommandsMarshaller.java:57)
>  ~[main/:?]
>       at 
> org.apache.ignite.internal.raft.server.impl.JraftServerImpl$WriteCommandIterator.next(JraftServerImpl.java:927)
>  ~[main/:?]
>       at 
> org.apache.ignite.internal.raft.server.impl.JraftServerImpl$WriteCommandIterator.next(JraftServerImpl.java:901)
>  ~[main/:?]
>       at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133) 
> ~[?:?]
>       at 
> org.apache.ignite.internal.table.distributed.raft.PartitionListener.onWrite(PartitionListener.java:249)
>  ~[main/:?]
>       at 
> org.apache.ignite.internal.raft.server.impl.JraftServerImpl$DelegatingStateMachine.onApply(JraftServerImpl.java:787)
>  ~[main/:?]{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to