Ivan Zlenko created IGNITE-25982:
------------------------------------

             Summary: Rework method ReplicaManager#replica
                 Key: IGNITE-25982
                 URL: https://issues.apache.org/jira/browse/IGNITE-25982
             Project: Ignite
          Issue Type: Improvement
            Reporter: Ivan Zlenko


Method ReplicaManager#replica is inconsistent with the javaDoc provided for 
this method:
{code:java}
    /**
     * Returns future with a replica if it was created or null if there no any 
replicas starting with given identifier.
     *
     * @param replicationGroupId Table-Partition identifier.
     * @return replica if it was created or null otherwise.
     */
    public CompletableFuture<Replica> replica(ReplicationGroupId 
replicationGroupId) {
        return replicas.get(replicationGroupId);
    }{code}
 

In javaDoc it is stated that this method could return null if no replica is 
started for given replication group, however the method is not marked as 
nullable.

We either need to mark it as nullable and fix all relevant code, or make this 
method return null future and fix the javaDoc.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to