[
https://issues.apache.org/jira/browse/IGNITE-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424103#comment-15424103
]
ASF GitHub Bot commented on IGNITE-3700:
----------------------------------------
GitHub user krosenvold opened a pull request:
https://github.com/apache/ignite/pull/962
IGNITE-3700 Fix behaviour of writeAll/deleteAll to comply with contract
This fixes #962
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/krosenvold/ignite IGNITE-3700
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/962.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #962
----
commit 113a27f4c824b641dd747f7a9875d5fd67c8eb4a
Author: Kristian Rosenvold <[email protected]>
Date: 2016-08-17T08:27:13Z
IGNITE-3700 Fix behaviour of writeAll/deleteAll to comply with contract
This fixes #962
----
> CacheWriter implementations should remove updated entries from the input
> collection
> -----------------------------------------------------------------------------------
>
> Key: IGNITE-3700
> URL: https://issues.apache.org/jira/browse/IGNITE-3700
> Project: Ignite
> Issue Type: Bug
> Components: cache
> Affects Versions: 1.7
> Reporter: Valentin Kulichenko
> Fix For: 1.8
>
>
> According to {{CacheWriter}} JavaDoc, bulk operations ({{writeAll}} and
> {{deleteAll}}) should remove successful entries from the input collection:
> {code}
> * If this operation fails (by throwing an exception) after a partial
> success,
> * the writer must remove any successfully written entries from the entries
> * collection so that the caching implementation knows what succeeded and
> can
> * mutate the cache.
> {code}
> We properly handle this in the cache store manager and throw
> {{CachePartialUpdateException}} with the list of keys not removed from the
> original collection. However, the implementations provided by Ignite
> ({{CacheStoreAdapter}}, {{CacheAbstractJdbcStore}}, etc.) ignore this and
> simply iterate through entries without removing successful ones.
> Proper implementation should use {{Iterator}} and remove the entry after
> successful update:
> {code}
> @Override public void writeAll(Collection<Cache.Entry<? extends Integer, ?
> extends Integer>> entries) throws CacheWriterException {
> Iterator<Cache.Entry<? extends Integer, ? extends Integer>> it =
> entries.iterator();
> while (it.hasNext()) {
> Cache.Entry<? extends Integer, ? extends Integer> entry = it.next();
> // Do actual write (can throw an exception).
> it.remove();
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
