[
https://issues.apache.org/jira/browse/IGNITE-26180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18025194#comment-18025194
]
Roman Puchkovskiy commented on IGNITE-26180:
--------------------------------------------
The patch looks good to me
> Add data region and data storage metrics
> ----------------------------------------
>
> Key: IGNITE-26180
> URL: https://issues.apache.org/jira/browse/IGNITE-26180
> Project: Ignite
> Issue Type: Improvement
> Reporter: Filipp Shergalis
> Assignee: Kirill Tkalenko
> Priority: Major
> Labels: ignite-3
> Fix For: 3.2
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> We need to add data storage metrics from AI2 to AI3
>
> * io_dataregion_<region_name>_PagesRead
> * io_dataregion_<region_name>_PagesWritten
> * io_datastorage_LastCheckpointLockWaitDuration
> * io_datastorage_LastCheckpointPagesWriteDuration
> * io_datastorage_LastCheckpointFsyncDuration
> * io_datastorage_LastCheckpointTotalPagesNumber
> * io_datastorage_LastCheckpointDuration
> * io_datastorage_StorageSize*
> Structure should be changed to convey that metrics (except last) make sense
> only for aipersist storage, not for RocksDB
>
> {{{}For every checkpoint we also track
> *onMarkCheckpointBeginDuration*{}}}{*}, {{{}writeLockHoldDuration{}}},
> {{{}replicatorLogSyncDuration{}}},
> {{{}splitAndSortCheckpointPagesDuration{}}}, {{waitPageReplacement,}}{*}{{
> these metrics should be added}}
>
>
> *From AI2 javadoc: *Size of the storage in bytes. May differ from pages() *
> getPageSize() due to delayed writes or due to other implementation specific
> details*
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
