Ivan Bessonov created IGNITE-26677:
--------------------------------------
Summary: Rework logging for CriticalHandshakeException Got
handshake start from self
Key: IGNITE-26677
URL: https://issues.apache.org/jira/browse/IGNITE-26677
Project: Ignite
Issue Type: Improvement
Reporter: Ivan Bessonov
Assignee: Ivan Bessonov
Error stack trace:
{code:java}
2025-09-11 08:54:56:617 +0000
[ERROR][gridgain-c1-0-network-worker-7][DefaultMessagingService] Handshake
failed [destNodeId=null, channelType=ChannelType [id=1, name=ScaleCube],
destAddr=/192.168.81.223:3344, localBindAddr=0.0.0.0/0.0.0.0:3344]
java.util.concurrent.CompletionException:
org.apache.ignite.internal.network.handshake.CriticalHandshakeException: Got
handshake start from self, this should never happen; this is a programming
error [localNode={id=fb3aac85-504b-45e7-b7c0-885cd7636512, name=gridgain-c1-0,
address=192.168.9.133:3344}, acceptorNode=ClusterNodeMessageImpl
[host=192.168.9.133, id=fb3aac85-504b-45e7-b7c0-885cd7636512,
name=gridgain-c1-0, port=3344]]
at java.base/java.util.concurrent.CompletableFuture.encodeRelay(Unknown
Source)
... {code}
The message itself has no significant negative impact. However, this creates
some level of worry for customers seeing:
* CriticalHandshakeException - critical exception is quite a strong word for
something that has no impact
* Huge stack trace - unnecessary logs, and overhead in storing logs.
* Message content - “{{{}this should never happen; this is a programming
error{}}}” is bad visual.
Improvement:
* Reduce the logging level
* Remove printing of stack trace
* Change the message. i.e. {{Got handshake start from self, this should never
happen}} or even just {{Got handshake start from self}} should be enough
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
