[
https://issues.apache.org/jira/browse/IGNITE-26508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maksim Timonin updated IGNITE-26508:
------------------------------------
Description:
MessageSerializer accepts buffer from ByteBufferStream, and invokes setBuffer
for every message. But it looks like every MessageWriter use the same buffer
every time, and this buffer is stored in
GridIoSelectorNioSessionImpl#writeBuffer.
We want to simplify API for MessageSerializer - remove buffer from readFrom,
writeTo. Buffer is an implementation specific detail.
Root changes:
# Remove ByteBuffer from MessageSerializer#writeTo, #readFrom
# Move setBuffer logic to DirectMessageReader/Writer
# Refactor ClientMessage handling in GridNioServer
was:
MessageSerializer accepts buffer from ByteBufferStream, and invokes setBuffer
for every message. But it looks like every MessageWriter use the same buffer
every time, and this buffer is stored in
GridIoSelectorNioSessionImpl#writeBuffer.
We want to simplify API for MessageSerializer - remove buffer from readFrom,
writeTo. Buffer is an implementation specific detail.
> DirectMessageWriter should incapsulate buffer
> ---------------------------------------------
>
> Key: IGNITE-26508
> URL: https://issues.apache.org/jira/browse/IGNITE-26508
> Project: Ignite
> Issue Type: Improvement
> Reporter: Maksim Timonin
> Priority: Major
> Labels: IEP-132, ise
> Time Spent: 20m
> Remaining Estimate: 0h
>
> MessageSerializer accepts buffer from ByteBufferStream, and invokes setBuffer
> for every message. But it looks like every MessageWriter use the same buffer
> every time, and this buffer is stored in
> GridIoSelectorNioSessionImpl#writeBuffer.
> We want to simplify API for MessageSerializer - remove buffer from readFrom,
> writeTo. Buffer is an implementation specific detail.
> Root changes:
> # Remove ByteBuffer from MessageSerializer#writeTo, #readFrom
> # Move setBuffer logic to DirectMessageReader/Writer
> # Refactor ClientMessage handling in GridNioServer
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
