[
https://issues.apache.org/jira/browse/IGNITE-26452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18032922#comment-18032922
]
Ignite TC Bot commented on IGNITE-26452:
----------------------------------------
{panel:title=Branch: [pull/12446/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/12446/head] Base: [master] : New Tests
(32)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Calcite SQL{color} [[tests
32|https://ci2.ignite.apache.org/viewLog.html?buildId=8665591]]
* {color:#013220}IgniteCalciteTestSuite:
CacheStoreTest.testCacheStoreOnDML[Engine=calcite, atomicityMode=ATOMIC,
cacheMode=PARTITIONED, backups=1, loadPreviousValue=true] - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite:
CacheStoreTest.testCacheStoreOnDML[Engine=calcite, atomicityMode=ATOMIC,
cacheMode=PARTITIONED, backups=1, loadPreviousValue=false] - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite:
CacheStoreTest.testCacheStoreOnDML[Engine=calcite, atomicityMode=ATOMIC,
cacheMode=REPLICATED, backups=0, loadPreviousValue=true] - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite:
CacheStoreTest.testCacheStoreOnDML[Engine=calcite, atomicityMode=ATOMIC,
cacheMode=REPLICATED, backups=0, loadPreviousValue=false] - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite:
CacheStoreTest.testCacheStoreOnDML[Engine=calcite, atomicityMode=ATOMIC,
cacheMode=PARTITIONED, backups=0, loadPreviousValue=true] - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite:
CacheStoreTest.testCacheStoreOnDML[Engine=calcite, atomicityMode=ATOMIC,
cacheMode=PARTITIONED, backups=0, loadPreviousValue=false] - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite:
CacheStoreTest.testCacheStoreOnDML[Engine=calcite, atomicityMode=TRANSACTIONAL,
cacheMode=PARTITIONED, backups=1, loadPreviousValue=true] - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite:
CacheStoreTest.testCacheStoreOnDML[Engine=calcite, atomicityMode=TRANSACTIONAL,
cacheMode=PARTITIONED, backups=1, loadPreviousValue=false] - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite:
CacheStoreTest.testCacheStoreOnDML[Engine=calcite, atomicityMode=TRANSACTIONAL,
cacheMode=REPLICATED, backups=0, loadPreviousValue=true] - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite:
CacheStoreTest.testCacheStoreOnDML[Engine=calcite, atomicityMode=TRANSACTIONAL,
cacheMode=REPLICATED, backups=0, loadPreviousValue=false] - PASSED{color}
* {color:#013220}IgniteCalciteTestSuite:
CacheStoreTest.testCacheStoreOnDML[Engine=calcite, atomicityMode=ATOMIC,
cacheMode=REPLICATED, backups=1, loadPreviousValue=true] - PASSED{color}
... and 21 new tests
{panel}
[TeamCity *--> Run :: All*
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=8665676&buildTypeId=IgniteTests24Java8_RunAll]
> SQL Calcite: INSERT operations in External Storage mode trigger
> CacheStore#load invocation
> ------------------------------------------------------------------------------------------
>
> Key: IGNITE-26452
> URL: https://issues.apache.org/jira/browse/IGNITE-26452
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 2.17
> Reporter: Andrei Nadyktov
> Assignee: Nikita Amelchev
> Priority: Minor
> Labels: ise
> Fix For: 2.18
>
> Attachments: CacheStoreLoadTests.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> It seems that we have an unnecessary {{CacheStore#load}} invocation when
> executing INSERT statements in Ignite.
> *Prerequisites:*
> # Ignite used as a caching layer to an existing database.
> # Write-Through, Read-Through are enabled.
> # Custom implementation of CacheStore is used.
> # Calcite engine is used.
> When inserting some rows into table, we expect that only {{CacheStore#write}}
> method will be invoked for writing data to an external database. What
> actually happens is that, for some unknown reasons, {{CacheStore#load}} is
> called before {{{}CacheStore#write{}}}. This may slow down overall
> performance due to redundant read operation from the external database.
> It seems that such behaviour is only reproduced when Calcite engine is
> enabled. This happens even with {{CacheConfiguration#setLoadPreviousValue}}
> flag set to false.
> *Reproducer:* [^CacheStoreLoadTests.patch]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
