[
https://issues.apache.org/jira/browse/IGNITE-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438419#comment-15438419
]
Alexey Kuznetsov commented on IGNITE-3314:
------------------------------------------
Igor, I reviewed PR and here my comments:
1) Could you please add some tests?
2) Could you use methods from "org.apache.ignite.internal.util.IgniteUtils"?
For example, see "org.apache.ignite.internal.binary.BinaryMetadata#writeTo"
method.
I recommend to use methods like "writeString, writeEnum".
Other than that looks good.
> Implement Serializable in
> org.apache.ignite.cache.store.cassandra.datasource.DataSource
> ---------------------------------------------------------------------------------------
>
> Key: IGNITE-3314
> URL: https://issues.apache.org/jira/browse/IGNITE-3314
> Project: Ignite
> Issue Type: Sub-task
> Components: cache
> Reporter: Igor Rudyak
> Assignee: Igor Rudyak
> Priority: Minor
> Fix For: 1.8
>
>
> Current implementation of
> org.apache.ignite.cache.store.cassandra.utils.datasource.DataSource doesn't
> implement Serializable, thus for distributed Ignite clusters,
> CassandraCacheStoreFactory could only be setup through Spring XML file, but
> not from code.
> New version of
> org.apache.ignite.cache.store.cassandra.utils.datasource.DataSource should
> implement Serializable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
