[
https://issues.apache.org/jira/browse/IGNITE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449161#comment-15449161
]
Andrew Mashenkov commented on IGNITE-2629:
------------------------------------------
OdbcThreadPool is instantiating before OdbcProcessor in IgnitionEx class with
other thread-pools. So, thread pool size parameters should be validate in their
use place, outside OdbcProcessor class.
Also, I've found that there is no checks of any pool size at all. An
IllegalArgumentException will be thrown from one of java standard
implementation of ThreadPool without any information about wrong parameter if
incorrect value provided.
We need to validate threadPoolSize parameter for all thread pools to prevent
user confusion.
> ODBC: Added GridNioAsyncNotifyFilter and GridConnectionBytesVerifyFilter to
> NIO server.
> ---------------------------------------------------------------------------------------
>
> Key: IGNITE-2629
> URL: https://issues.apache.org/jira/browse/IGNITE-2629
> Project: Ignite
> Issue Type: Task
> Components: odbc
> Affects Versions: 1.5.0.final
> Reporter: Vladimir Ozerov
> Assignee: Andrew Mashenkov
> Fix For: 1.8
>
>
> This is low-priority task, lets return to it once everything else is finished.
> Justification:
> 1) *GridNioAsyncNotifyFilter* moves requests processing to separate thread
> pool. If you do no do that, all NIO workers might stuck in potentially
> long-running query operations and you will not be able to accept new client
> requests what may result in timeouts on client side.
> 2) *GridConnectionBytesVerifyFilter* expects special magic header to ensure
> connected client identity.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
