[ 
https://issues.apache.org/jira/browse/IGNITE-27771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roman Puchkovskiy updated IGNITE-27771:
---------------------------------------
    Description: 
Ideally, DefaultMessagingService should not log any exceptions that it returns 
to the caller as it's responsibility of the caller to log them. Some time ago, 
exception logging was added in DefaultMessagingService to facilitate debugging 
difficult cases like 'handshake fails as node tries to send to itself via 
network'. Now, this additional logging code also logs other exceptions which 
were never supposed to be logged there.

We should only log HandshakeExceptions not caused by IO exceptions there.

Also, we should only bother about exceptions happening while opening a channel 
and doing a handshake.

> Reduce logging on handshake error
> ---------------------------------
>
>                 Key: IGNITE-27771
>                 URL: https://issues.apache.org/jira/browse/IGNITE-27771
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Roman Puchkovskiy
>            Assignee: Roman Puchkovskiy
>            Priority: Major
>              Labels: ignite-3
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Ideally, DefaultMessagingService should not log any exceptions that it 
> returns to the caller as it's responsibility of the caller to log them. Some 
> time ago, exception logging was added in DefaultMessagingService to 
> facilitate debugging difficult cases like 'handshake fails as node tries to 
> send to itself via network'. Now, this additional logging code also logs 
> other exceptions which were never supposed to be logged there.
> We should only log HandshakeExceptions not caused by IO exceptions there.
> Also, we should only bother about exceptions happening while opening a 
> channel and doing a handshake.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to