[ 
https://issues.apache.org/jira/browse/IGNITE-28050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ilya Shishkov updated IGNITE-28050:
-----------------------------------
    Description: 
{{StartRoutineAckDiscoveryMessage}}, {{StartRoutineDiscoveryMessage}}, 
{{StartRoutineDiscoveryMessageV2}} should  use {{MessageSerializer}}.
Also, it seems that {{StartRoutineDiscoveryMessage}} seems to be redundant and 
should removed if possible.

  was:
Excessive wrapping and tangled class hierarchy complicate migration of 
discovery custom messages to the new message framework:
{{DiscoveryCustomMessage}} is wrapped into {{CustomMessageWrapper}} (implements 
{{DiscoverySpiCustomMessage}}), which in turn is wrapped by 
{{TcpDiscoveryCustomEventMessage}} ({{TcpDiscoveryAbstractMessage}} hierarchy).
 
*What can be done:*
* {{CustomMessageWrapper}} (extends {{DiscoverySpiCustomMessage}}) can be 
deleted, it is just a wrapper.
* {{DiscoverySpiCustomMessage}} interface is redundant. Can be temporary 
transformed into ordinary class (issue for complete deletion IGNITE-27778).
* All {{DiscoverySpiCustomMessage}} inheritors can inherit from 
{{DiscoveryCustomMessage}}


> Use MessageSerializer for StartRoutineAckDiscoveryMessage, 
> StartRoutineDiscoveryMessage, StartRoutineDiscoveryMessageV2
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-28050
>                 URL: https://issues.apache.org/jira/browse/IGNITE-28050
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Ilya Shishkov
>            Priority: Major
>              Labels: IEP-132, ise
>             Fix For: 2.19
>
>
> {{StartRoutineAckDiscoveryMessage}}, {{StartRoutineDiscoveryMessage}}, 
> {{StartRoutineDiscoveryMessageV2}} should  use {{MessageSerializer}}.
> Also, it seems that {{StartRoutineDiscoveryMessage}} seems to be redundant 
> and should removed if possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to