[ 
https://issues.apache.org/jira/browse/IGNITE-28099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Valuyskiy updated IGNITE-28099:
------------------------------------
    Description: 
h1. Description

Currently the warning about page-based eviction start is logged only once per 
node, even if eviction starts in multiple data regions. The message is printed 
from {*}IgniteCacheDatabaseSharedManager#warnFirstEvict{*}:
{code:java}
Page-based evictions started. Consider increasing 'maxSize' on Data Region 
configuration: <region-name>{code}
Although the log message contains the data region name, the internal flag 
*firstEvictWarn* is global for the whole 
{*}IgniteCacheDatabaseSharedManager{*}. As a result, the warning is printed 
only for the first data region where eviction starts and is suppressed for all 
subsequent regions.

This behavior may be misleading in configurations with multiple data regions. 
If eviction starts in another region later, there will be no corresponding 
warning in the logs.
h1. Proposed change

Change the eviction warning logic so that the message is logged once per data 
region, instead of once per node.

Expected behavior:
 * The warning is printed when eviction starts in a data region for the first 
time.
 * If eviction later starts in another data region, the warning is printed 
again for that region.
 * The warning should still be printed only once per region to avoid log 
flooding.

  was:
Currently the warning about page-based eviction start is logged only once per 
node, even if eviction starts in multiple data regions.

The message is printed from IgniteCacheDatabaseSharedManager#warnFirstEvict:

Page-based evictions started. Consider increasing 'maxSize' on Data Region 
configuration: <region-name>

Although the log message contains the data region name, the internal flag 
firstEvictWarn is global for the whole IgniteCacheDatabaseSharedManager. As a 
result, the warning is printed only for the first data region where eviction 
starts and is suppressed for all subsequent regions.

This behavior can be misleading in configurations with multiple data regions. 
If eviction starts in another region later, there will be no corresponding 
warning in the logs.

Proposed change

Change the eviction warning logic so that the message is logged once per data 
region, instead of once per node.

Expected behavior:

The warning is printed when eviction starts in a data region for the first time.

If eviction later starts in another data region, the warning is printed again 
for that region.

The warning should still be printed only once per region to avoid log flooding.


> Make page eviction start warning logged per data region instead of once per 
> node
> --------------------------------------------------------------------------------
>
>                 Key: IGNITE-28099
>                 URL: https://issues.apache.org/jira/browse/IGNITE-28099
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Oleg Valuyskiy
>            Assignee: Oleg Valuyskiy
>            Priority: Minor
>              Labels: ise
>
> h1. Description
> Currently the warning about page-based eviction start is logged only once per 
> node, even if eviction starts in multiple data regions. The message is 
> printed from {*}IgniteCacheDatabaseSharedManager#warnFirstEvict{*}:
> {code:java}
> Page-based evictions started. Consider increasing 'maxSize' on Data Region 
> configuration: <region-name>{code}
> Although the log message contains the data region name, the internal flag 
> *firstEvictWarn* is global for the whole 
> {*}IgniteCacheDatabaseSharedManager{*}. As a result, the warning is printed 
> only for the first data region where eviction starts and is suppressed for 
> all subsequent regions.
> This behavior may be misleading in configurations with multiple data regions. 
> If eviction starts in another region later, there will be no corresponding 
> warning in the logs.
> h1. Proposed change
> Change the eviction warning logic so that the message is logged once per data 
> region, instead of once per node.
> Expected behavior:
>  * The warning is printed when eviction starts in a data region for the first 
> time.
>  * If eviction later starts in another data region, the warning is printed 
> again for that region.
>  * The warning should still be printed only once per region to avoid log 
> flooding.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to