[ 
https://issues.apache.org/jira/browse/IGNITE-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469242#comment-15469242
 ] 

Roman Shtykh edited comment on IGNITE-532 at 9/7/16 2:13 AM:
-------------------------------------------------------------

Hi [~Chandresh Pancholi]

_(It seems Semen has started the review, but since I had a look at your code, I 
will write my comments too)_
Putting aside minor issues, in your implementation what the actor is doing is 
just creating a new streamer with data on invocation. To process it, you use 
`AkkaStreamer` that has no relation to the created actor. I would recommend to 
revise the code keeping in mind how it will be used the the user.
As I see it, each actor invocation has to inject data into Ignite (as in 
earlier Dmitriy's and Joshua's discussion).



was (Author: roman_s):
Hi [~Chandresh Pancholi]

_(It seems Semen has started the review, but since I had a look at your code, I 
will write my comments too)_
Putting aside minor issues, in your implementation what the actor is doing is 
just creating a new streamer with data on invocation. To process it, you use 
`AkkaStreamer` that has no relation to the created actor. I would recommend to 
revise the code keeping in mind how it will be used the the user.
As I see it, each actor invocation has to inject data into Ignite.


> Implement IgniteAkkaStreamer to stream data from Akka actors.
> -------------------------------------------------------------
>
>                 Key: IGNITE-532
>                 URL: https://issues.apache.org/jira/browse/IGNITE-532
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: streaming
>            Reporter: Dmitriy Setrakyan
>            Assignee: Semen Boikov
>
> We have {{IgniteDataStreamer}} which is used to load data into Ignite under 
> high load. It was previously named {{IgniteDataLoader}}, see ticket 
> IGNITE-394.
> See [Akka|http://akka.io/] for more information. Given that Akka is a Scala 
> frameworks, this streamer should be available in Scala.
> We should create {{IgniteAkkaStreamer}} which will consume messages from Akka 
> Actors and stream them into Ignite caches.
> More details to follow, but to the least we should be able to:
> * Convert data from Akka to Ignite using an optional pluggable converter. If 
> not provided, then we should have some default mechanism.
> * Specify the cache name for the Ignite cache to load data into.
> * Specify other flags available on {{IgniteDataStreamer}} class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to