[
https://issues.apache.org/jira/browse/IGNITE-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15473345#comment-15473345
]
Pavel Tupitsyn edited comment on IGNITE-3199 at 9/8/16 12:03 PM:
-----------------------------------------------------------------
1) I'm ok with LockInfo rename, but as for collection, I don't agree. This
collection has nothing to do with WebSession per se. Classes should be named
according to what they do, not where they are used. This collection can be used
in any other scenario.
2) I've only added what is necessary. We normally don't add any platform things
to BinaryContext (see filters, predicates, etc). But here we need these three
classes because they are serialized from .NET, and Java won't understand them
initially.
3) Good point, done.
4) Done.
5) This is according to the docs (see MSDN link above).
6) Done.
7) There are only 2 duplicated lines. Logic is very different, returned result
is different. Merging these two will be a mess. Let's keep concerns separated.
8) Fixed.
9) I've extracted this logic to a separate class, but I'm not sure how do you
want to inject it to PlatformCache. I mean, where do we inject it from?
PlatformProcessor creates PlatformCache, but why should it know about these
processors?
10) Fixed.
was (Author: ptupitsyn):
1) I'm ok with LockInfo rename, but as for collection, I don't agree. This
collection has nothing to do with WebSession per se. Classes should be named
according to what they do, not where they are used. This collection can be used
in any other scenario.
2) I've only added what is necessary. We normally don't add any platform things
to BinaryContext (see filters, predicates, etc). But here we need these three
classes because they are serialized from .NET, and Java won't understand them
initially.
3) Good point, done.
4) Done.
5) This is according to the docs (see MSDN link above).
6) Done.
7) There are only 2 duplicated lines. Logic is very different, returned result
is different. Merging these two will be a mess. Let's keep concerns separated.
8) Fixed.
> .NET: ASP.NET Session-State Store Provider
> ------------------------------------------
>
> Key: IGNITE-3199
> URL: https://issues.apache.org/jira/browse/IGNITE-3199
> Project: Ignite
> Issue Type: Sub-task
> Components: platforms
> Affects Versions: 1.7
> Reporter: Pavel Tupitsyn
> Assignee: Pavel Tupitsyn
> Labels: .net
> Fix For: 1.8
>
>
> See https://msdn.microsoft.com/en-us/library/ms178587.aspx
> Code should be put to Apache.Ignite.AspNet assembly (see IGNITE-2379)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
