Vladimir Steshin created IGNITE-28636:
-----------------------------------------

             Summary: Do not check message type by raw numbers.
                 Key: IGNITE-28636
                 URL: https://issues.apache.org/jira/browse/IGNITE-28636
             Project: Ignite
          Issue Type: Improvement
            Reporter: Vladimir Steshin


In {_}GridCacheIoManager{_}:

 
{code:java}
switch (msg.directType()) {
    case 10022:

    case 10016:

    case 10303: 

    case 10305:

    case 10300: 
...{code}
 

In {_}IgniteTxManager{_}:
{code:java}
switch (msg.directType()) {
    case 10003: 

    case 10004:

 ...{code}
We should not use raw numbers to detect message type. At least constants should 
be involved. Or {_}instanceof{_}. Or we might ask the factory some how.

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to