[
https://issues.apache.org/jira/browse/IGNITE-28667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18081953#comment-18081953
]
Ignite TC Bot commented on IGNITE-28667:
----------------------------------------
{panel:title=Branch: [pull/13128/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/13128/head] Base: [master] : New Tests
(3)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Basic 1{color} [[tests
3|https://ci2.ignite.apache.org/viewLog.html?buildId=9076784]]
* {color:#013220}IgniteBasicTestSuite:
MessageFactoryMarshallerInitializationTest.testInitFromDiscovery - PASSED{color}
* {color:#013220}IgniteBasicTestSuite:
MessageFactoryMarshallerInitializationTest.testInitFromPlugin - PASSED{color}
* {color:#013220}IgniteBasicTestSuite:
MessageFactoryMarshallerInitializationTest.testInitFromPluginAndDiscovery -
PASSED{color}
{panel}
[TeamCity *--> Run :: All*
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=9076911&buildTypeId=IgniteTests24Java8_RunAll]
{color:#ffffff}tcbot-analysis-comment chainBuildId=9076911
rerunBuildIds=9078385,9078387,9078389{color}
> Initialize message factory provider for extensions
> --------------------------------------------------
>
> Key: IGNITE-28667
> URL: https://issues.apache.org/jira/browse/IGNITE-28667
> Project: Ignite
> Issue Type: Task
> Reporter: Ilya Shishkov
> Assignee: Ilya Shishkov
> Priority: Major
> Labels: IEP-132, ise
> Fix For: 2.19
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, {{IgniteKernal#initMessageFactory}} misses to call
> {{#initProvider}} for message factory providers, obtained from extension
> registry.
> It is necessary to initialize {{MessageFactoryProvider}} registered *_from a
> plugin_*.
>
> {code:java}
> private void initMessageFactory() throws IgniteCheckedException {
> >>>>>>>>> MessageFactoryProvider[] msgs =
> ctx.plugins().extensions(MessageFactoryProvider.class); <<<<<<<<<
> List<MessageFactoryProvider> compMsgs = new ArrayList<>();
> ClassLoader resolvedClsLdr = U.resolveClassLoader(ctx.config());
> compMsgs.add(new
> CoreMessagesProvider(ctx.marshallerContext().jdkMarshaller(),
> ctx.marshaller(), resolvedClsLdr));
> for (IgniteComponentType compType : IgniteComponentType.values()) {
> MessageFactoryProvider f = compType.messageFactory();
> if (f != null) {
> >>>>>>>>> initProvider(f, resolvedClsLdr); <<<<<<<<<
> compMsgs.add(f);
> }
> }
> DiscoverySpi discoSpi = ctx.config().getDiscoverySpi();
> if (discoSpi instanceof IgniteDiscoverySpi) {
> MessageFactoryProvider discoMsgs =
> ((IgniteDiscoverySpi)discoSpi).messageFactoryProvider();
> if (discoMsgs != null) {
> >>>>>>>>> initProvider(discoMsgs, resolvedClsLdr); <<<<<<<<<
> compMsgs.add(discoMsgs);
> }
> }
> if (!compMsgs.isEmpty())
> msgs = F.concat(msgs, compMsgs.toArray(new
> MessageFactoryProvider[compMsgs.size()]));
> msgFactory = new IgniteMessageFactoryImpl(msgs);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
