[
https://issues.apache.org/jira/browse/IGNITE-27767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18098313#comment-18098313
]
Aleksandr Mokretsov commented on IGNITE-27767:
----------------------------------------------
Hello!
I have a few questions about this task:
1) How should we handle tests? Should we duplicate all existing tests or just
replace every `Foo(null, ...)` with `Foo(...)`?
2) After a quick look, I noticed some potential issues with certain overloads.
For example:
- First case: If we add `IQueryable<T> AsQueryable(QueryableOptions? options =
null)`, there will be an ambiguous invocation when someone calls
`AsQueryable()` without arguments. We could fix this by adding an extra
overload `IQueryable<T> AsQueryable()`. Is that acceptable?
- Second case: If we add `Task<bool> ReplaceAsync(T record, T newRecord)`,
we'll have ambiguity as well. If a client has something like
`PocoView.ReplaceAsync(null, GetPoco(1, "1"))`, they'll get the same ambiguity
error and would be forced to use an explicit cast or remove the null argument.
Is that okay? Actually, it looks like the Java library accepted this "breaking
change" and added explicit casts to their tests.
> .NET: Add overloads for common API methods without Transaction
> --------------------------------------------------------------
>
> Key: IGNITE-27767
> URL: https://issues.apache.org/jira/browse/IGNITE-27767
> Project: Ignite
> Issue Type: Improvement
> Components: platforms ai3, thin clients ai3
> Reporter: Pavel Tupitsyn
> Assignee: Aleksandr Mokretsov
> Priority: Major
> Labels: ignite-3
> Fix For: 3.2
>
>
> See IGNITE-25403 - implement the same API changes in .NET client.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
