[
https://issues.apache.org/jira/browse/IGNITE-28936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18100528#comment-18100528
]
Anton Vinogradov edited comment on IGNITE-28936 at 7/30/26 7:23 PM:
--------------------------------------------------------------------
[Ignite PR Checker|https://ignite-pr-checker.is-a.dev/?pr=13419] verdict for PR
13419 · RunAll build [9240892|https://ci2.ignite.apache.org/build/9240892] ·
147 suites ran, 0 reused
(/) *No blockers* — nothing in this run looks caused by this PR. 26
pre-existing/flaky tests filtered out.
♻️ Settled after 1 auto re-run wave(s): #1 — 4 blocker suite(s).
was (Author: av):
[Ignite PR Checker|https://ignite-pr-checker.is-a.dev/?pr=13419] verdict for PR
13419 · RunAll build [9240892|https://ci2.ignite.apache.org/build/9240892] ·
147 suites ran, 0 reused
(x) *4 blocker(s) in 4 suite(s):*
- Continuous Query 4:
{{org.apache.ignite.testsuites.IgniteCacheQuerySelfTestSuite6:
org.apache.ignite.internal.processors.performancestatistics.PerformanceStatisticsQueryTest.testIndexQuery[pageSize=100,
clientType=SERVER]}}
- Queries 3: {{org.apache.ignite.testsuites.IgniteBinaryCacheQueryTestSuite3:
org.apache.ignite.internal.processors.query.IgniteSqlNotNullConstraintTest.testAlterTableAddColumnNotNullFieldAllowed}}
- Binary Objects: {{org.apache.ignite.testsuites.IgniteBinaryObjectsTestSuite:
org.apache.ignite.internal.processors.cache.binary.BinaryMetadataRemoveWithPersistenceTest.testRemoveTypeOnNodes}}
- Cache 6: {{org.apache.ignite.testsuites.IgniteCacheTestSuite6:
org.apache.ignite.internal.processors.cache.distributed.CacheExchangeMergeTest.testMergeServersFail1_5}}
⏳ _Auto re-run *#1* in progress — 4 blocker suite(s) re-queued (attempt 1/2),
*≈ settled by 22:16 MSK*. This comment updates when they settle._
> Remove dead marshalling code from GridDhtAtomicUpdateRequest
> ------------------------------------------------------------
>
> Key: IGNITE-28936
> URL: https://issues.apache.org/jira/browse/IGNITE-28936
> Project: Ignite
> Issue Type: Sub-task
> Components: messaging
> Reporter: Anton Vinogradov
> Assignee: Anton Vinogradov
> Priority: Major
> Labels: compatibility
> Fix For: 2.19
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> *Wire format change. Do this before 2.19 is released - after that it would
> break rolling upgrade.*
> h3. Goal
> Delete code that can never run, and fields that are always empty.
> h3. Why
> {{GridDhtAtomicUpdateRequest#forceTransformBackups}} is always {{false}}.
> Both places that create this message pass {{false}}:
> {{GridDhtAtomicUpdateFuture}} and {{GridDhtAtomicSingleUpdateFuture}}. All
> code under this flag is dead. Entry processors are never added, so the
> hand-written {{marshal}} and {{unmarshal}} have nothing to write, and three
> collection fields are always {{null}}.
> h3. How
> * delete {{entryProcessors}}, {{nearEntryProcessors}} and {{invokeArgs}};
> * delete the wire fields {{@Order(12) entryProcessorsBytes}}, {{@Order(13)
> nearEntryProcessorsBytes}}, {{@Order(14) invokeArgsBytes}};
> * delete {{@Order(11) forceTransformBackups}} and the constructor parameter,
> and update both callers;
> * delete {{marshal(Marshaller)}}, {{unmarshal(Marshaller, ClassLoader)}}, the
> {{MarshallableMessage}} interface and {{@UseBinaryMarshaller}};
> * renumber the remaining {{@Order}} values.
> h3. Expected result
> Every DHT atomic update request sends 4 fields less: one boolean and three
> empty collections. The class does not need a marshaller any more.
> h3. How to verify
> Atomic cache tests, including {{EntryProcessor}} and near cache updates. Full
> build with {{-Pcheckstyle}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
