[
https://issues.apache.org/jira/browse/IGNITE-28943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101136#comment-18101136
]
Ignite TC Bot commented on IGNITE-28943:
----------------------------------------
{panel:title=Branch: [pull/13423/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/13423/head] Base: [master] : No new tests
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=9245888&buildTypeId=IgniteTests24Java8_RunAll]
{color:#ffffff}tcbot-analysis-comment chainBuildId=9245888
rerunBuildIds=none{color}
> Cleanup in SecurityBasicPermissionSetSerializationTest and
> MessageProcessorTest
> -------------------------------------------------------------------------------
>
> Key: IGNITE-28943
> URL: https://issues.apache.org/jira/browse/IGNITE-28943
> Project: Ignite
> Issue Type: Test
> Reporter: Dmitry Werner
> Assignee: Dmitry Werner
> Priority: Trivial
> Time Spent: 40m
> Remaining Estimate: 0h
>
> 1. In SecurityBasicPermissionSetSerializationTest#testWriteAndReadBack, the
> line `src.setCachePermissions(Map.of("cache", Set.of(CACHE_CREATE,
> CACHE_PUT)));` is duplicated.
> In method deepEquals, there is a typo where lhs is missing. The condition
> checks rhs twice:
> {code:java}
> (F.isEmpty(rhs.systemPermissions()) &&
> F.isEmpty(rhs.systemPermissions())){code}
> 2. MessageProcessorTest#testCustomMapperCannotBeUsedOnNonEnumCollection test
> should verify the compilation of CustomEnumMapperOnNonEnumCollectionMessage,
> not CustomEnumMapperOnArrayFieldMessage.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
