[
https://issues.apache.org/jira/browse/IGNITE-28953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101876#comment-18101876
]
Anton Vinogradov commented on IGNITE-28953:
-------------------------------------------
[Ignite PR Checker|https://ignite-pr-checker.is-a.dev/?pr=13434] verdict for PR
13434 · RunAll build [9253664|https://ci2.ignite.apache.org/build/9253664] ·
147 suites ran, 0 reused
(!) *This run doesn't cover the PR fully:*
- 1 suite(s) have no reliable result (compilation error, timeout, crash)
- 1 suite(s) ran far fewer tests than the same suites on master
(!) *1 broken suite(s)* (failed without a reliable run):
- Cache (Failover) 5: execution timeout · non-zero exit code · Number of tests
33 is 51% less than 67 in build #452
(?) *1 suite(s) ran fewer tests than on master* (tests that never ran can't
fail):
- Cache (Failover) 5: 33 tests vs 67 on master (*-51%*)
(?) *No blockers found — but the run above can't prove the PR is clean.* 19
pre-existing/flaky tests filtered out. Re-run once the above is sorted out.
⏳ _Auto re-run *#1* in progress — 1 broken suite(s) re-queued (attempt 1/2), *≈
settled by 00:55 MSK*. This comment updates when they settle._
> Calcite: PlanExecutionTest and ContinuousExecutionTest fail after
> IGNITE-28937 due to uninitialized message factory
> -------------------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-28953
> URL: https://issues.apache.org/jira/browse/IGNITE-28953
> Project: Ignite
> Issue Type: Bug
> Components: messaging
> Reporter: Anton Vinogradov
> Assignee: Anton Vinogradov
> Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 1h
> Remaining Estimate: 0h
>
> IGNITE-28937 added an assert to
> AbstractMarshallableMessageFactoryProvider.loadGenerated(): when a generated
> companion constructor takes a Marshaller, the provider must be initialized
> via init() first. In production IgniteKernal#initProvider() always calls
> init(), so the assert never fires there.
> PlanExecutionTest and ContinuousExecutionTest create CalciteMessageFactory
> without calling init() (they only need direct type registration), so 38 tests
> fail in the Calcite SQL 2 suite with:
> {noformat}java.lang.AssertionError: QueryStartRequestMarshaller takes a
> marshaller, but none was provided
> at
> org.apache.ignite.internal.plugin.AbstractMarshallableMessageFactoryProvider.loadGenerated(AbstractMarshallableMessageFactoryProvider.java:118){noformat}
> Fix: initialize the factory with jdk marshallers in these tests, the same way
> core tests do (see CoreMessagesProvider usages with Marshallers.jdk()).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
