[
https://issues.apache.org/jira/browse/IGNITE-28920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18102600#comment-18102600
]
Vladimir Steshin edited comment on IGNITE-28920 at 8/6/26 8:18 PM:
-------------------------------------------------------------------
[~av] , to me, some Message interface extending like `beforeSending()` and
`received()` looks normal. Message could do some optimizations, compactions
before and after transmission. Timeout-related routines should be updated right
after message read, before putting to the processing queue. I'm not sure that
Message should not be aware of it transmission processing.
was (Author: vladsz83):
[~av] , to me, some Message interface extending like `beforeSending()` and
`received()` looks normal. Message could do some optimizations, compactions
before and after transmission. Timeout-related routines should be updated right
after message read, befire putting to a processing queue. I'm not sure that a
Message should not be aware of it transmission processing.
> Reduce MarshallableMessage scope: GridCacheEntryInfo uses marshal hooks only
> to rebase expireTime
> -------------------------------------------------------------------------------------------------
>
> Key: IGNITE-28920
> URL: https://issues.apache.org/jira/browse/IGNITE-28920
> Project: Ignite
> Issue Type: Task
> Reporter: Anton Vinogradov
> Priority: Major
> Labels: IEP-132, wire-format
> Fix For: 2.19
>
>
> GridCacheEntryInfo implements MarshallableMessage, but its
> marshal()/unmarshal() hooks never use the Marshaller: marshal() converts the
> absolute expireTime into a remaining TTL before send, and unmarshal()
> restores the absolute value on the receiver, compensating clock differences
> between nodes. MarshallableMessage should stay reserved for messages that
> actually carry marshalled payload. Proposal: move the expireTime rebase out
> of the marshalling hooks and drop the MarshallableMessage interface from
> GridCacheEntryInfo. Same cleanup direction as IGNITE-28914
> (GridDhtPartitionsFullMessage).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
