[ 
https://issues.apache.org/jira/browse/IGNITE-25518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18108911#comment-18108911
 ] 

Ignite TC Bot commented on IGNITE-25518:
----------------------------------------

I reviewed implementation PR #12107 and commit 8f855a4fc2 in the local Ignite 2 
checkout. This adds validation for duplicate cache group names during snapshot 
restore and returns a clear IllegalArgumentException for an invalid input case; 
it does not change the documented snapshot restore syntax or add a new 
user-facing option. I removed only Docs Required and preserved Release Notes 
Required.

> Snapshot restore fails with IllegalStateException when duplicate cache group 
> names are provided in the collection
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-25518
>                 URL: https://issues.apache.org/jira/browse/IGNITE-25518
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Vladislav Novikov
>            Assignee: Vladislav Novikov
>            Priority: Major
>              Labels: ise
>             Fix For: 2.18
>
>         Attachments: reproducer.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When calling {{restoreSnapshot}} and passing a collection of cache group 
> names that contains *duplicate entries* , an {{IllegalStateException}} is 
> thrown with the message:
> {{(err) Failed to notify listener (is grid stopped?) [fut=GridFutureAdapter 
> [ignoreInterrupts=false, state=DONE, 
> res=o.a.i.i.processors.cache.persistence.snapshot.SnapshotPartitionsVerifyTaskResult@65754192,
>  hash=1714739685], 
> lsnr=o.a.i.i.processors.cache.persistence.snapshot.SnapshotRestoreProcess$$Lambda$1276/0x00000008008cac40@43ec83dc,
>  err=Duplicate key 280828085 (attempted merging values testCacheGrp and 
> testCacheGrp)]java.lang.IllegalStateException: Duplicate key 280828085 
> (attempted merging values testCacheGrp and testCacheGrp)}}
> and the snapshot restore procedure freezes.
> To reproduce the error, apply the patch attached here to master and run 
> {{{}SnapshotCompatibilityTest#testSnapshotRestore{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to