[
https://issues.apache.org/jira/browse/IGNITE-29047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113860#comment-18113860
]
Ignite TC Bot commented on IGNITE-29047:
----------------------------------------
{panel:title=Branch: [pull/13574/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/13574/head] Base: [master] : New Tests
(1)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Basic 4{color} [[tests
1|https://ci2.ignite.apache.org/viewLog.html?buildId=9337620]]
* {color:#013220}IgniteBasicTestSuite2:
FailureProcessorMetricsTest.testIgnoredFailuresCountMetric - PASSED{color}
{panel}
[TeamCity *--> Run :: All*
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=9337762&buildTypeId=IgniteTests24Java8_RunAll]
{color:#ffffff}tcbot-analysis-comment chainBuildId=9337762
rerunBuildIds=none{color}
> Add ignored failure count metric to FailureProcessor
> ----------------------------------------------------
>
> Key: IGNITE-29047
> URL: https://issues.apache.org/jira/browse/IGNITE-29047
> Project: Ignite
> Issue Type: Task
> Reporter: Dmitry Werner
> Assignee: Dmitry Werner
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the event "Possible failure suppressed accordingly to a configured
> handler" is only reported via the log by FailureProcessor. There is no way to
> track how often such failures occur without parsing (grepping) the log.
> We need to expose this as a metric so the count of suppressed (ignored)
> failures can be monitored through the metrics subsystem (e.g. JMX, system
> views, exporters) instead of relying on log parsing.
> *Proposed change*
> - Register a new metric group failure (register name: failure) in
> FailureProcessor.
> - Add a counter metric IgnoredFailuresCount that is incremented every time a
> failure is suppressed (ignored) by the configured failure handler — i.e.
> exactly where IGNORED_FAILURE_LOG_MSG is printed.
> - Keep the existing log message unchanged.
> - Document the new metric in docs/_docs/monitoring-metrics/new-metrics.adoc.
> *Acceptance criteria*
> - The metric is exposed and readable through the standard metrics subsystem.
> - The metric increases by 1 for each suppressed failure and is not affected
> by failures processed normally (not ignored).
> - A unit test covers the above behavior.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
