[
https://issues.apache.org/jira/browse/IGNITE-29174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolay Izhikov updated IGNITE-29174:
-------------------------------------
Labels: ise (was: )
> Cleanup of binary modules: remove GridBinaryMarshaller#reader/#writer, final
> BinaryContext fields, misc simplifications
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-29174
> URL: https://issues.apache.org/jira/browse/IGNITE-29174
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Nikolay Izhikov
> Assignee: Nikolay Izhikov
> Priority: Major
> Labels: ise
>
> Small cleanups in the binary modules collected while extracting
> ignite-binary-impl. No behaviour change.
> * Remove {{GridBinaryMarshaller#reader(BinaryInputStream)}} and
> {{GridBinaryMarshaller#writer(BinaryOutputStream)}}; callers use
> {{BinaryUtils.reader/writer}} with a {{BinaryContext}}.
> {{PlatformUtils.marshaller()}} becomes {{binaryContext()}}.
> * Make {{BinaryContext#marsh}} and {{BinaryContext#marshCtx}} final. Drop the
> {{sysLdr}} field: a {{null}} loader in {{descriptorForTypeId}} already falls
> back to {{CommonUtils.gridClassLoader()}} inside {{ClassLoaderUtils.forName}}.
> * {{MarshallerUtils.addClassNames}} drops the class loader parameter that was
> always {{CommonUtils.gridClassLoader()}}.
> * {{BinaryObjectImpl}} and {{BinaryObjectOffheapImpl}}: replace the
> {{reader(null, false)}} overload with a no-argument {{reader()}}.
> * Move {{BinaryUtils.resolveClass}} to {{BinaryImplUtils}} (used only by
> {{BinaryArray}} and {{BinaryEnumObjectImpl}}).
> * {{BinaryWriterExImpl}} constructor becomes package-private.
> * Remove unused {{IgniteUtils.unmarshalZip}} (the only user was a test, which
> keeps a local copy).
> * {{DumpReader}}, {{SharedFsCheckpointSpi}}, {{OptimizedMarshallerImpl}}: use
> {{gridClassLoader()}} / {{JdkMarshaller}} directly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)