[ 
https://issues.apache.org/jira/browse/IGNITE-29182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18129417#comment-18129417
 ] 

Ignite TC Bot commented on IGNITE-29182:
----------------------------------------

{panel:title=Branch: [pull/13716/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/13716/head] Base: [master] : No new tests 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All* 
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=9427606&buildTypeId=IgniteTests24Java8_RunAll]
{color:#ffffff}tcbot-analysis-comment chainBuildId=9427606 
rerunBuildIds=none{color}

> Fix flaky SystemViewSnapshotsTest.testSnapshot
> ----------------------------------------------
>
>                 Key: IGNITE-29182
>                 URL: https://issues.apache.org/jira/browse/IGNITE-29182
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Dmitry Werner
>            Assignee: Dmitry Werner
>            Priority: Minor
>              Labels: MakeTeamcityGreenAgain
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> [https://ci2.ignite.apache.org/test/4772259840278572252?currentProjectId=IgniteTests24Java8&branch=%3Cdefault%3E]
> SystemViewSnapshotsTest.testSnapshot failed with stacktrace:
> org.junit.ComparisonFailure: expected:<[testGroup,MetaStorage]> but 
> was:<[MetaStorage,testGroup]>
> at org.junit.Assert.assertEquals(Assert.java:117)
> at org.junit.Assert.assertEquals(Assert.java:146)
> at 
> org.apache.ignite.testframework.junits.JUnitAssertAware.assertEquals(JUnitAssertAware.java:65)
> at 
> org.apache.ignite.internal.metric.SystemViewSnapshotsTest.testSnapshot(SystemViewSnapshotsTest.java:85)
> *Root cause*
> The cacheGroups() value in the snapshot system view is built in 
> IgniteSnapshotManager from SnapshotFileTree.existingCacheDirs(), which uses 
> File.listFiles() — an unspecified, filesystem-dependent order.
> The test asserted an exact comma-joined string with a hardcoded order, so the 
> test is a flake: it only passes when the filesystem happens to return 
> testGroup before MetaStorage.
> *Fix*
> Make the assertion order-independent in SystemViewSnapshotsTest - compare as 
> sets.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to