[ 
https://issues.apache.org/jira/browse/IGNITE-29095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Steshin updated IGNITE-29095:
--------------------------------------
    Description: 
 `IgniteSnapshotManager's`
{code:java}
deleteLocalSnapshot(File snpDir)
or
deleteLocalSnapshot(SnapshotFileTree sft, boolean scoped == true, boolean 
ignoreErrs){code}
 attempts to delete the local node's snapshot data, as well as the shared 
snapshot data folder if it is empty. Note: nodes may share their work and 
snapshots directories.

However, the method misses the subdirectories containing incremental parts. 
This is not an issue if a snapshot is deleted completely (e.g., as in 
#IGNITE-29050), because in that case the entire snapshot folder is removed.

If we delete data from specific nodes only, we should also account for the 
`{_}IncrementalSnapshotFileTree`{_}

  was:
`{_}IgniteSnapshotManager#deleteSnapshot(SnapshotFileTree sft){_}` attempts to 
delete the local node's snapshot data, as well as the shared snapshot data 
folder if it is empty. Note: nodes may share their work and snapshots 
directories.

However, the method misses the subdirectories containing incremental parts. 
This is not an issue if a snapshot is deleted completely (e.g., as in 
#IGNITE-29050), because in that case the entire snapshot folder is removed.

If we delete data from specific nodes only, we should also account for the 
`{_}IncrementalSnapshotFileTree`{_}


> IgniteSnapshotManager#deleteSnapshot ignores incremental snapshots
> ------------------------------------------------------------------
>
>                 Key: IGNITE-29095
>                 URL: https://issues.apache.org/jira/browse/IGNITE-29095
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Vladimir Steshin
>            Priority: Minor
>
>  `IgniteSnapshotManager's`
> {code:java}
> deleteLocalSnapshot(File snpDir)
> or
> deleteLocalSnapshot(SnapshotFileTree sft, boolean scoped == true, boolean 
> ignoreErrs){code}
>  attempts to delete the local node's snapshot data, as well as the shared 
> snapshot data folder if it is empty. Note: nodes may share their work and 
> snapshots directories.
> However, the method misses the subdirectories containing incremental parts. 
> This is not an issue if a snapshot is deleted completely (e.g., as in 
> #IGNITE-29050), because in that case the entire snapshot folder is removed.
> If we delete data from specific nodes only, we should also account for the 
> `{_}IncrementalSnapshotFileTree`{_}



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to