[
https://issues.apache.org/jira/browse/IGNITE-29208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132584#comment-18132584
]
Anton Vinogradov commented on IGNITE-29208:
-------------------------------------------
[Ignite PR Checker|https://ignite-pr-checker.is-a.dev/?pr=13750] verdict for PR
13750 · RunAll build [9444214|https://ci2.ignite.apache.org/build/9444214] ·
tested
[346ba80|https://github.com/apache/ignite/pull/13750/commits/346ba80aaf43294f52cf772abeadda6231a4a68d]
· 149 suites ran, 0 reused
(!) *This run doesn't cover the PR fully:*
- mixed run — Basic 2, Calcite SQL 3 and Data Structures 2 re-ran on f9a0b28,
the rest of the RunAll ran on 346ba80; only a RunAll of the PR's head can prove
it clean
Everything below is what it did manage to say.
(?) *No blockers found — but the run above can't prove the PR is clean.* 30
failing tests are not blamed on this PR. Re-run after you handle what is listed
above.
_What each label means and what to do: [verdict
glossary|https://github.com/anton-vinogradov/ignite-pr-checker/blob/main/docs/features.md#verdict-glossary]._
_The PR is now at {{f9a0b28}}._
♻️ Settled after 1 auto re-run wave: #1 — 5 suites that failed mid-run.
> Preserve SSLEngine peer address in SSLContextWrapper
> ----------------------------------------------------
>
> Key: IGNITE-29208
> URL: https://issues.apache.org/jira/browse/IGNITE-29208
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Anton Vinogradov
> Assignee: Anton Vinogradov
> Priority: Major
> Labels: ise
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> SSLContextWrapper drops the peer host and port passed to
> createSSLEngine(host, port). Forward them to the matching delegate overload
> while retaining the configured SSLParameters.
> Add a regression test through the existing public constructor that checks
> peer host, port, and configured protocols and ciphers. Keep the no-argument
> overload working. This fix must not depend on the reload implementation.
> Land this independent fix first to keep the later SSL API change focused.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
