[ 
https://issues.apache.org/jira/browse/IGNITE-29281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18143526#comment-18143526
 ] 

Ignite TC Bot commented on IGNITE-29281:
----------------------------------------

{panel:title=Branch: [pull/13819/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/13819/head] Base: [master] : New Tests 
(5)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Calcite SQL 3{color} [[tests 
5|https://ci2.ignite.apache.org/viewLog.html?buildId=9491439]]
* 
{color:#013220}org.apache.ignite.internal.processors.query.calcite.integration.QueryCleanupRaceIntegrationTest.testDeleteFailureWithDelayedQueryStartResponse
 - PASSED{color}
* 
{color:#013220}org.apache.ignite.internal.processors.query.calcite.integration.QueryCleanupRaceIntegrationTest.testPlanningFailureClosesQuery
 - PASSED{color}
* 
{color:#013220}org.apache.ignite.internal.processors.query.calcite.integration.QueryCleanupRaceIntegrationTest.testExecutionFailureHasAcyclicExceptionGraph
 - PASSED{color}
* 
{color:#013220}org.apache.ignite.internal.processors.query.calcite.integration.QueryCleanupRaceIntegrationTest.QueryCleanupRaceIntegrationTest
 - PASSED{color}
* 
{color:#013220}org.apache.ignite.internal.processors.query.calcite.integration.QueryCleanupRaceIntegrationTest.testPlanningFailureClosesEarlierStatement
 - PASSED{color}

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=9489653&buildTypeId=IgniteTests24Java8_RunAll]
{color:#ffffff}tcbot-analysis-comment chainBuildId=9489653 
rerunBuildIds=9491433,9491435,9491437,9491439,9491441,9491443{color}

> SQL Calcite: Fix Query cleanup race
> -----------------------------------
>
>                 Key: IGNITE-29281
>                 URL: https://issues.apache.org/jira/browse/IGNITE-29281
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.18, 2.19
>            Reporter: Kirill Tkalenko
>            Assignee: Kirill Tkalenko
>            Priority: Major
>              Labels: calcite, ignite-2, sql
>         Attachments: QueryCleanupRaceIntegrationTest.java
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> A race between query failure handling and {{QueryStartResponse}} processing 
> can leave a failed query registered on a remote node.
> After a DELETE fails, {{CalciteQueryProcessor.processQuery()}} unregisters 
> the client’s {{RootQuery}} while it is still {{CLOSING}} and waiting for a 
> fragment start response. The response handler then cannot find the query, so 
> cleanup does not complete and {{QueryCloseMessage}} is never sent.
> Besides test cleanup failures, this may retain query objects and execution 
> resources, increase memory usage after repeated failures, and leave stale 
> entries in query monitoring.
> The race was observed without artificial delays while running in a container 
> with two CPUs available on relatively low-powered hardware. I have not 
> explicitly observed it on TeamCity. The attached synthetic reproducer delays 
> {{QueryStartResponse}} until a DELETE fails, then releases it and checks 
> cleanup. It fails before the fix and passes afterward.
> See [^QueryCleanupRaceIntegrationTest.java]



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to