[ 
https://issues.apache.org/jira/browse/IGNITE-29161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksandr Chesnokov updated IGNITE-29161:
-----------------------------------------
    Description: 
A change to serialization code can change the bytes on the wire while the 
generated JSON stays the same. Find out whether a hash of the code can help 
reviewers spot those changes.

Decide which code to include in the hash and what reviewers should do when it 
changes. This proposal is tracked separately in the plan in IGNITE-25489.

  was:This is an idea from the earlier plan under IGNITE-25489. Generated JSON 
describes message structure, but a change in serialization code can affect the 
bytes without changing that structure. A code hash could help make such changes 
visible. Before implementation, agree which code the hash should cover and how 
reviewers should use it. This work needs a separate scope decision and is not a 
prerequisite for IGNITE-29261 or IGNITE-29145. The current plan generates 
descriptions in CI rather than committing {{wire/}} files.

        Summary: Evaluate code hashes for wire format review  (was: Add a code 
hash to message JSON files)

> Evaluate code hashes for wire format review
> -------------------------------------------
>
>                 Key: IGNITE-29161
>                 URL: https://issues.apache.org/jira/browse/IGNITE-29161
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Aleksandr Chesnokov
>            Assignee: Aleksandr Chesnokov
>            Priority: Major
>
> A change to serialization code can change the bytes on the wire while the 
> generated JSON stays the same. Find out whether a hash of the code can help 
> reviewers spot those changes.
> Decide which code to include in the hash and what reviewers should do when it 
> changes. This proposal is tracked separately in the plan in IGNITE-25489.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to