Nikita Amelchev created IGNITE-29307:
----------------------------------------

             Summary: Fix performance regression of BinaryUtils#isBinaryArray 
after IGNITE-29158
                 Key: IGNITE-29307
                 URL: https://issues.apache.org/jira/browse/IGNITE-29307
             Project: Ignite
          Issue Type: Bug
            Reporter: Nikita Amelchev
            Assignee: Nikita Amelchev


IGNITE-29158 replaced the class check in {{BinaryUtils#isBinaryArray}} ({{{}val 
instanceof BinaryArray{}}}) with an interface check ({{{}val instanceof 
BinaryObjectEx && isArray(){}}}). The method is called from 
{{CacheObjectUtils#unwrapBinary}} for every column value of every row read by 
the Calcite engine, where values are plain {{{}Integer{}}}/{{{}String{}}} 
objects, so the check always fails, and on JDK 17 a failed interface check is a 
linear scan over the interfaces of the value class (JDK-8180450). This slows 
down Calcite SQL queries: the throughput of the sql-calcite-query benchmark 
dropped after the commit.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to