[ 
https://issues.apache.org/jira/browse/IGNITE-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524978#comment-15524978
 ] 

Alexey Kuznetsov commented on IGNITE-3609:
------------------------------------------

Igor, I reviewed PR and have several questions:
 1) Method 
*org.apache.ignite.cache.store.cassandra.persistence.PojoValueField#init* has 
commented body. Looks like a bug.
 2) In Method *CassandraHelper.isTableAbsenceError* entry.getValue() evaluated 
several times, may be declare a variable?
 3) CassandraSessionImpl, CassandraCacheStore, CassandraDirectPersistenceTest 
and TestsHelper contains imports with wildcards. In Ignite we are not using 
wildcard imports. Please fix.
 4) Class TestTransaction does not have javadoc and Apache license header.
 5) CassandraLocalServer does not have Apache license header.

Also could you describe mutations? How they work? Do you have a test for them?



> Utilize Cassandra logged batches for transactions
> -------------------------------------------------
>
>                 Key: IGNITE-3609
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3609
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: cache
>            Reporter: Igor Rudyak
>            Assignee: Igor Rudyak
>             Fix For: 1.8
>
>
> Utilize Cassandra logged batches to atomically persist transaction changes in 
> persistent store



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to