[
https://issues.apache.org/jira/browse/IGNITE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525527#comment-15525527
]
Semen Boikov commented on IGNITE-3965:
--------------------------------------
Hi,
I still see some issues:
- in GridJobProcessor it is not correct to use 'internal()' method to create
session, correct way is use 'req.isInternal()'
- in GridTaskProcessor you call 'dep.internalTask', but at this line 'dep' can
be null, you need move session creation after 'dep' is checked for null
- also since you initialize 'internal' flag for session we can use this value
in GridTaskWorker:493 instead of calling 'dep.internalTask' one more time
Thanks
> @GridInternal tasks should not go through user load balancing SPI
> -----------------------------------------------------------------
>
> Key: IGNITE-3965
> URL: https://issues.apache.org/jira/browse/IGNITE-3965
> Project: Ignite
> Issue Type: Bug
> Components: compute
> Affects Versions: 1.6
> Reporter: Alexey Kuznetsov
> Assignee: Semen Boikov
> Fix For: 1.8
>
>
> User can specify some custom load balancing SPI, but internal task should use
> default load balancing SPI with predictable behaviour.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
