[ 
https://issues.apache.org/jira/browse/IGNITE-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602191#comment-15602191
 ] 

Taras Ledkov edited comment on IGNITE-4062 at 10/24/16 2:43 PM:
----------------------------------------------------------------

[Tests 
results|http://195.239.208.174/project.html?projectId=IgniteTests&tab=projectOverview&branch_IgniteTests=pull%2F1182%2Fhead]


was (Author: tledkov-gridgain):
[Tests 
resuslts|http://195.239.208.174/project.html?projectId=IgniteTests&tab=projectOverview&branch_IgniteTests=pull%2F1182%2Fhead]

> BinaryObject header should not participate in equals test
> ---------------------------------------------------------
>
>                 Key: IGNITE-4062
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4062
>             Project: Ignite
>          Issue Type: Bug
>          Components: binary
>    Affects Versions: 1.7
>            Reporter: Valentin Kulichenko
>            Assignee: Taras Ledkov
>            Priority: Critical
>             Fix For: 1.8
>
>
> {{BinaryObject.equals()}} compares the full byte array, which can give 
> incorrect results in come cases. For example, we sometimes write full class 
> name instead of type ID, so two objects that are equal from user's standpoint 
> will have different binary representation and {{equals()}} will return false.
> We should make {{equals()}} implementation more smart and compare separately:
> * type ID
> * hash code
> * portion of byte array that contains actual data, i.e. fields without header 
> and footer



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to