[
https://issues.apache.org/jira/browse/IGNITE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605685#comment-15605685
]
Saikat Maitra commented on IGNITE-1943:
---------------------------------------
[~anovikov]
Hi Andrey,
Thank you for reviewing the PR. As far as I understand the mclear command clear
entries of the mem Map object used by visor to hold node number, host ip
address and other variables used to capture and display metrics. The current
implemented function assignNodeValue does the same operation as nodeJoinLsnr
Predicate called in open function. It populates the map with ignite cluster
node number and host ip details. This same function will be called if the mem
map is empty during node and task command execution.
Can you please elaborate on the desired functionality of mcompact command.
Regards
Saikat
> ignitevisorcmd: wrong behavior for "mclear" command
> ---------------------------------------------------
>
> Key: IGNITE-1943
> URL: https://issues.apache.org/jira/browse/IGNITE-1943
> Project: Ignite
> Issue Type: Bug
> Components: general
> Affects Versions: 1.5.0.final
> Reporter: Vasilisa Sidorova
> Assignee: Saikat Maitra
> Fix For: 1.8
>
>
> ---------------------------------------------
> DESCRIPTION
> ---------------------------------------------
> "mclear" should clears all Visor console variables before they will be
> updated during next run of the corresponding command. It OK for all type of
> shortcut (@cX, @tX, @aX, @eX) exept shortcut for node-id variables. After
> "mclear" @nX are disappear from any statistics
> ---------------------------------------------
> STEPS FOR REPRODUCE
> ---------------------------------------------
> # Start cluster
> # Start visorcmd ([IGNITE_HOME]/bin/ignitevisorcmd.sh)
> # Connect to the started cluster (visor> open)
> # Execute any tasks in it (for example, run any example from EventsExample,
> DeploymentExample, ComputeContinuousMapperExample, ComputeTaskMapExample,
> ComputeTaskSplitExample)
> # Create several alerts (visor> alert)
> # Run visor "mclear" command
> # Run visor "node" command
> ---------------------------------------------
> ACTUAL RESULT
> ---------------------------------------------
> There isn't @nX values in the first table's column:
> {noformat}
> visor> node
> Select node from:
> +==================================================================+
> | # | Node ID8(@), IP | Up Time | CPUs | CPU Load | Free Heap |
> +==================================================================+
> | 0 | 6B3E4033, 127.0.0.1 | 00:38:41 | 8 | 0.20 % | 97.00 % |
> | 1 | 0A0D6989, 127.0.0.1 | 00:38:22 | 8 | 0.17 % | 97.00 % |
> | 2 | 0941E33F, 127.0.0.1 | 00:35:46 | 8 | 0.23 % | 97.00 % |
> +------------------------------------------------------------------+
> {noformat}
> ---------------------------------------------
> EXPECTED RESULT
> ---------------------------------------------
> There is @nX values in the first table's column:
> {noformat}
> visor> node
> Select node from:
> +=======================================================================+
> | # | Node ID8(@), IP | Up Time | CPUs | CPU Load | Free Heap |
> +=======================================================================+
> | 0 | 6B3E4033(@n0), 127.0.0.1 | 00:38:13 | 8 | 0.23 % | 97.00 % |
> | 1 | 0A0D6989(@n1), 127.0.0.1 | 00:37:54 | 8 | 0.27 % | 97.00 % |
> | 2 | 0941E33F(@n2), 127.0.0.1 | 00:35:18 | 8 | 0.20 % | 97.00 % |
> +-----------------------------------------------------------------------+
> {noformat}
> "mclear" should get effect only for "mget @nX" command (with result "Missing
> variable with name: '@nX'") and @nX variables should get new values after
> "node" (or "tasks") command execution. Like in case for all others @
> variables (@cX, @tX, @aX, @eX)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
