[ 
https://issues.apache.org/jira/browse/IGNITE-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614799#comment-15614799
 ] 

Semen Boikov commented on IGNITE-2523:
--------------------------------------

Hi Konstantin,

There are still few comments:
- I committed minor changes in branch, please take a look
- please add test for GridNearAtomicSingleUpdateFilterRequest in 
CacheAtomicSingleMessageCountSelfTest
- need handle GridNearAtomicSingleUpdateFilterRequest in 
GridCacheIoManager.processFailedMessage
- even if expiry policy is not null we can still use 
GridNearAtomicSingleUpdateFuture, but just do not use 'single' messages in this 
case
- we usually organize 'flags' field in different way (do not need keep boolean 
fields 'fastMap', 'hasPrimary', etc in 
GridNearAtomicAbstractSingleUpdateRequest), look for example at IgniteTxEntry
- message size after optimization is still not impressive, maybe you have any 
ideas how we can further improve this?

Thanks!

> Introduce "single put" NEAR update request.
> -------------------------------------------
>
>                 Key: IGNITE-2523
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2523
>             Project: Ignite
>          Issue Type: Task
>          Components: cache
>    Affects Versions: 1.5.0.final
>            Reporter: Vladimir Ozerov
>            Assignee: Konstantin Dudkov
>              Labels: performance
>             Fix For: 1.8
>
>
> Essentially, in this case we could get rid of all collections and garbage 
> inside GridNearAtomicUpdateRequest/GridDhtAtomicUpdateRequest.
> This should drastically decrease message size and improve performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to